Patch Review Process
====================

The development process of Transifex includes a pre-commit review phase, taking place at http://review.transifex.org/.

This means that before we commit a large change, we publish it for review from the rest of the developers, in order to improve its quality before it lands in the versioning system and get the consensus of the community for the changes.

The review platform we are using is `Review Board`_, written in Django by the cool guys at VMWare.

How it works
------------

Small commits are pushed by the committers directly in the mainline. Larger commits are uploaded to RB first as Review Requests, and a request is sent to the IRC channel or the mailing list for a review.

Here a few tips to request a review:

- Grab a diff of yours (eg. with ``hg diff`` or ``hg commit && hg export tip > foo.diff``.
- Create a new request at http://review.transifex.org/. Use the group 'transifex' in your review.
- If the patch changes the UI, and you'd like feedback for it, you can attach a screenshot with the review.
- Write how other developers can test it. Ideally this should be as much automated as possible.
- If you have included all the changes proposed or the flag 'ship it' is up, you can commit, and push or email the patch for inclusion in the mainline.

.. _Review Board: http://review-board.org/