Ticket #543 (closed defect: fixed)
Environment is not inherited by default when running comands
| Reported by: | ricky | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 0.8.1 |
| Component: | Core | Version: | |
| Keywords: | Cc: | ||
| Easy Task: | no | Blocked By: | |
| Blocking: | Ready for Review: | yes | |
| Patch Review: | Needs Patch: | no |
Description
On Fedora's Transifex instance, we noticed that git commands were not inheriting the proper environment when called from Transifex. This patch passes None to subprocess.Popen, which triggers the default behavior of inheriting the environment from the original process:
diff -r 3f20ee4a3423 transifex/txcommon/commands.py
--- a/transifex/txcommon/commands.py Thu Mar 11 18:26:40 2010 -0300
+++ b/transifex/txcommon/commands.py Thu Mar 11 19:06:19 2010 -0500
@@ -80,7 +80,7 @@
with_extended_output = kw.pop('with_extended_output', False)
with_exceptions = kw.pop('with_exceptions', True)
with_raw_output = kw.pop('with_raw_output', False)
- env = kw.pop('env', {})
+ env = kw.pop('env', None)
# if command is a string split to a list
Change History
Note: See
TracTickets for help on using
tickets.
