Ticket #478 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

ENABLE_REVIEWS = False still shows all the interface elements

Reported by: nick Owned by: diegobz
Priority: major Milestone: 0.8
Component: Core Version: devel
Keywords: Cc:
Blocked By: Blocking:
Easy Task: no Needs Patch: no
Ready for Review: Patch Review:

Description

Summary says it all: Disabling reviews still shows the review buttons all over the place.

Change History

comment:1 Changed 2 years ago by glezos

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r1171. We'll have reviews always enabled.

comment:2 Changed 2 years ago by nick

If you are going to fix things this way, then please give priority to shared translations groups because this is not going to work for Xfce.

comment:3 Changed 2 years ago by glezos

Nick, can we have some more specific info on this? The idea is that everyone can open reviews but only committers (team members, team coordinators, maintainers) can close them.

comment:4 Changed 2 years ago by nick

When also team members can close them I can make it work for us, but i think i stumbled on a permission problem, the "Close Review" buttons are never shown. Even if i give a user all permissions they don't show up, only when I check the "Supersuser status" box.

comment:5 Changed 2 years ago by diegobz

Nick's comment:4 seems to be another issue. Just open #479 for it.

Note: See TracTickets for help on using tickets.