Ticket #451 (assigned defect)

Opened 8 months ago

Last modified 4 months ago

RTL issue in Transifix

Reported by: lashar Owned by: diegobz
Priority: major Milestone: 0.8.1
Component: View/Templates Version:
Keywords: rtl Cc:
Easy Task: yes Blocked By:
Blocking: Ready for Review: yes
Patch Review: Needs Patch: no

Description (last modified by lashar) (diff)

Hey.
As far as I remember Persian (fa) and Balochi are ther first languages that are available in Tx which are RTL langugages. As I check screenshot( http://img697.yfrog.com/img697/2467/mostafa.png) provided by OgMaciel? I see that text decoration in django for showing text in fa locale is left rather than right.

Attachments

base-bidi.css Download (14.5 KB) - added by lashar 8 months ago.
tx-bidi.diff Download (1.3 KB) - added by diegobz 8 months ago.
Initial patch but it still need some work.

Change History

Changed 8 months ago by lashar

  • description modified (diff)

Changed 8 months ago by diegobz

We need to override the css style when the LANGUAGE_BIDI is true

Example:

{% get_current_language_bidi as LANGUAGE_BIDI %}

{% if LANGUAGE_BIDI %}
  <link media="screen" href="/site_media/css/base-bidi.css" type="text/css" rel="stylesheet" />
{% endif %}

References:
 http://whatsup.org.il/meir/talks/django-i18n/django-i18n.html
 http://www.djangobook.com/en/1.0/chapter18/

Changed 8 months ago by lashar

Changed 8 months ago by diegobz

Initial patch but it still need some work.

Changed 6 months ago by lashar

  • keywords rtl added
  • ready_for_review unset

does the new release contain this patch? any commit?

Changed 6 months ago by glezos

  • status changed from new to assigned
  • ready_for_review set
  • easy_task set
  • needs_patch unset
  • component changed from Core to View/Templates
  • milestone set to 0.8.1
  • owner set to diegobz

lashar, oh sorry about this. The ticket wasn't attached to the release and kinda slipped under our feet.

Do we have a way to test this patch? Is it working against the current mainline HEAD/tip?

Also, could you please include some screenshots and/or ways to test it?

I'm attaching it to 0.8.1, so if you can provide us with the above we could ship it very soon.

Note: See TracTickets for help on using tickets.